comphead commented on code in PR #9485:
URL: https://github.com/apache/arrow-datafusion/pull/9485#discussion_r1515304348
##########
datafusion/physical-expr/src/window/lead_lag.rs:
##########
@@ -400,10 +369,10 @@ mod tests {
test_i32_result(
lead(
"lead".to_owned(),
- DataType::Float32,
+ DataType::Int32,
Review Comment:
The test was fixed, imho it was not consistent testing f32 datatype against
i32 batch.
It worked because of additional unnecessary casting inside which is not
likely in real world
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
