kou commented on code in PR #40392:
URL: https://github.com/apache/arrow/pull/40392#discussion_r1515360635
##########
cpp/src/arrow/ipc/metadata_internal.cc:
##########
@@ -477,7 +477,9 @@ static Status GetDictionaryEncoding(FBB& fbb, const
std::shared_ptr<Field>& fiel
static KeyValueOffset AppendKeyValue(FBB& fbb, const std::string& key,
const std::string& value) {
- return flatbuf::CreateKeyValue(fbb, fbb.CreateString(key),
fbb.CreateString(value));
+ auto fbb_key_ = fbb.CreateString(key);
+ auto fbb_value_ = fbb.CreateString(value);
Review Comment:
Please don't use `_` suffix. We use it only for member variable (not local
variable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
