bkietz commented on code in PR #39067:
URL: https://github.com/apache/arrow/pull/39067#discussion_r1516424704
##########
cpp/src/arrow/util/visibility.h:
##########
@@ -80,4 +82,6 @@
#define ARROW_FRIEND_EXPORT
#define ARROW_TEMPLATE_EXPORT
+#define ARROW_FORCE_EXPORT [[gnu::visibility("default")]]
Review Comment:
This is what ARROW_EXPORT expands to for clang and gcc, defining it empty
would seem inconsistent. Additionally this is used in `filesystem_library.h`,
which might be used in a third party library where we don't control compile
options. If they set default visibility to hidden for example, declaring
`ARROW_FORCE_EXPORT void* arrow_filesystem_get_registry()` should give this a
better chance of just working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
