zeroshade commented on code in PR #1594:
URL: https://github.com/apache/arrow-adbc/pull/1594#discussion_r1516630595
##########
go/adbc/driver/flightsql/flightsql_connection.go:
##########
@@ -64,10 +64,16 @@ func doGet(ctx context.Context, cl *flightsql.Client,
endpoint *flight.FlightEnd
}
var (
- cc interface{}
+ cc interface{}
+ hasFallback bool
)
for _, loc := range endpoint.Location {
+ if loc.Uri == flight.LocationReuseConnection {
+ hasFallback = true
+ continue
+ }
Review Comment:
shouldn't we `break` instead of `continue`? or at least do the same as we do
below and attempt to reuse the connection, continuing the loop if it errors,
returning if it succeeds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
