Dandandan commented on pull request #9416: URL: https://github.com/apache/arrow/pull/9416#issuecomment-773475305
Thanks @ritchie46 A change I did recently in the sort kernel is to use an implementation of *totalOrder* for floats, which is a revision on IEEE 754. I think it would be great if we could be consistent with that change as well here + it would probably make the implementation easier and avoids problems you mention as well. What do you think? The code is here: https://github.com/apache/arrow/blob/master/rust/arrow/src/compute/kernels/sort.rs#L44 The definition of total order is documented here: https://doc.rust-lang.org/std/primitive.f64.html#method.total_cmp ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
