jayzhan211 commented on code in PR #9496:
URL: https://github.com/apache/arrow-datafusion/pull/9496#discussion_r1517283578
##########
datafusion/optimizer/src/analyzer/rewrite_expr.rs:
##########
@@ -118,11 +118,59 @@ impl TreeNodeRewriter for OperatorToFunctionRewriter {
args: vec![left, right],
})));
}
+
+ // TODO: change OperatorToFunction to OperatoToArrayFunction and
configure it with array_expressions feature
+ // after other array functions are udf-based
+ #[cfg(feature = "array_expressions")]
+ if let Some(expr) = rewrite_array_has_all_operator_to_func(left,
op, right) {
+ return Ok(Transformed::yes(expr));
+ }
}
Ok(Transformed::no(expr))
}
}
+#[cfg(feature = "array_expressions")]
Review Comment:
This rule is disabled, but other analyzer rules are not. As long as
`array_expressions ` is disabled, related function should be disabled too. Even
there implement their own array functions, those functions are not equal to our
udf based array functions, so it makes sense to me that the rewrite rule is
disabled too.
##########
datafusion/optimizer/src/analyzer/rewrite_expr.rs:
##########
@@ -118,11 +118,59 @@ impl TreeNodeRewriter for OperatorToFunctionRewriter {
args: vec![left, right],
})));
}
+
+ // TODO: change OperatorToFunction to OperatoToArrayFunction and
configure it with array_expressions feature
+ // after other array functions are udf-based
+ #[cfg(feature = "array_expressions")]
+ if let Some(expr) = rewrite_array_has_all_operator_to_func(left,
op, right) {
+ return Ok(Transformed::yes(expr));
+ }
}
Ok(Transformed::no(expr))
}
}
+#[cfg(feature = "array_expressions")]
Review Comment:
This rule is disabled, but other analyzer rules are not. As long as
`array_expressions ` is disabled, related function should be disabled too. Even
their implement their own array functions, those functions are not equal to our
udf based array functions, so it makes sense to me that the rewrite rule is
disabled too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
