seberg commented on code in PR #40418:
URL: https://github.com/apache/arrow/pull/40418#discussion_r1517526758
##########
python/pyarrow/src/arrow/python/numpy_to_arrow.cc:
##########
@@ -296,7 +296,7 @@ class NumPyConverter {
PyArrayObject* mask_;
int64_t length_;
int64_t stride_;
- int itemsize_;
+ int64_t itemsize_;
Review Comment:
Hmmm, maybe because this line has to be adjusted as well?
https://github.com/apache/arrow/blob/27f15abeba7ffc350896439038ff0b9749111610/python/pyarrow/src/arrow/python/numpy_to_arrow.cc#L566
Unless that is a 32bit system I don't think `intp` vs. `int64` is relevant.
I used `int64` because you are using it for shape/strides which are also `intp`
in NumPy, but of course `ssize_t` works also (if you have it defined).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
