lidavidm commented on code in PR #1597:
URL: https://github.com/apache/arrow-adbc/pull/1597#discussion_r1517952147
##########
go/adbc/driver/flightsql/flightsql_connection.go:
##########
@@ -95,6 +97,115 @@ func doGet(ctx context.Context, cl *flightsql.Client,
endpoint *flight.FlightEnd
return nil, err
}
+func (c *cnxn) getSessionOptions(ctx context.Context) (map[string]interface{},
error) {
+ ctx = metadata.NewOutgoingContext(ctx, c.hdrs)
+ var header, trailer metadata.MD
+ rawOptions, err := c.cl.GetSessionOptions(ctx,
&flight.GetSessionOptionsRequest{}, grpc.Header(&header),
grpc.Trailer(&trailer), c.timeouts)
+ if err != nil {
+ // We're going to make a bit of a concession to backwards
compatibility
+ // here and ignore UNIMPLEMENTED or INVALID_ARGUMENT
Review Comment:
because that's what dremio and others send
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
