alamb commented on code in PR #5471:
URL: https://github.com/apache/arrow-rs/pull/5471#discussion_r1518232536
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -244,16 +244,35 @@ impl<W: Write + Send> ArrowWriter<W> {
self.writer.append_key_value_metadata(kv_metadata)
}
+ /// Returns a reference to the underlying writer.
+ pub fn inner(&self) -> &W {
+ self.writer.inner()
+ }
+
+ /// Returns a mutable reference to the underlying writer.
+ ///
+ /// It is inadvisable to directly write to the underlying writer.
+ pub fn inner_mut(&mut self) -> &mut W {
+ self.writer.inner_mut()
+ }
+
/// Flushes any outstanding data and returns the underlying writer.
pub fn into_inner(mut self) -> Result<W> {
self.flush()?;
self.writer.into_inner()
}
/// Close and finalize the underlying Parquet writer
- pub fn close(mut self) -> Result<crate::format::FileMetaData> {
+ ///
Review Comment:
My rationale for this suggestion was to make it easier for someone to
quickly determine "what is the difference between the very similarly sounding
`finish()` and `close()` methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
