comphead commented on code in PR #9498:
URL: https://github.com/apache/arrow-datafusion/pull/9498#discussion_r1518232867
##########
datafusion/sqllogictest/test_files/window.slt:
##########
@@ -4227,13 +4249,18 @@ NULL def NULL def
# LEAD window function IGNORE/RESPECT NULLS support with descending order and
nondefault offset.
# To trigger WindowAggExec, we added a sum window function with all of the
ranges.
-statement error Execution error: IGNORE NULLS mode for LAG and LEAD is not
supported for WindowAggExec
+query TTTTI
select lead(a, 2, null) ignore nulls over (order by id desc) as x1,
lead(a, 2, 'def') ignore nulls over (order by id desc) as x2,
lead(a, 2, null) respect nulls over (order by id desc) as x4,
lead(a, 2, 'def') respect nulls over (order by id desc) as x5,
sum(id) over (order by id desc ROWS BETWEEN UNBOUNDED PRECEDING AND
UNBOUNDED FOLLOWING) as sum_id
from (select 2 id, 'b' a union all select 1 id, null a union all select 3 id,
null union all select 4 id, 'x')
+----
Review Comment:
this test is not the same as Spark or Trino.
Their result
```
x1|x2 |x4|x5 |sum_id|
--+---+--+---+------+
|def|b |b | 10|
|def| | | 10|
|def| |def| 10|
|def| |def| 10|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
