milenkovicm commented on PR #9482: URL: https://github.com/apache/arrow-datafusion/pull/9482#issuecomment-1986983413
Thanks a lot @alamb, your additions totally make sense. One question for you, is there a plan to add `simplify` to other function types? Also, inspired by simplification you've done in `SessionContext`, maybe we should add companion object to `FunctionFactory` so it can register configuration as well. At the moment its a bit of work to register configuration: https://github.com/milenkovicm/torchfusion/blob/634c2a4e39b81e1969671db8faea50b96bc43c7f/src/lib.rs#L101 ```rust let mut session_config = SessionConfig::new().with_information_schema(true); session_config .options_mut() .extensions // register torch factory configuration .insert(TorchConfig::default()); ``` it would be much better if config could be registered when `ctx.with_function_factory(...)` called ... but that could be a follow up PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
