jorgecarleitao commented on pull request #9413:
URL: https://github.com/apache/arrow/pull/9413#issuecomment-773732420
You were right, @jhorstmann , it has no significant impact and I thus
removed the `unsafe` version and made all checks happen. Thanks a lot for that
idea!
```
add 512 time: [1.0077 us 1.0126 us 1.0181 us]
change: [+5.0339% +6.3889% +7.6813%] (p = 0.00 <
0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low mild
3 (3.00%) high mild
3 (3.00%) high severe
subtract 512 time: [962.12 ns 968.88 ns 976.54 ns]
change: [+2.2544% +3.6466% +4.9816%] (p = 0.00 <
0.05)
Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
6 (6.00%) high mild
2 (2.00%) high severe
multiply 512 time: [964.18 ns 967.85 ns 971.69 ns]
change: [-0.1040% +1.4543% +2.7701%] (p = 0.04 <
0.05)
Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) low mild
3 (3.00%) high mild
2 (2.00%) high severe
divide 512 time: [2.8418 us 2.8454 us 2.8492 us]
change: [-0.8891% -0.2418% +0.3257%] (p = 0.45 >
0.05)
No change in performance detected.
Found 12 outliers among 100 measurements (12.00%)
2 (2.00%) low mild
4 (4.00%) high mild
6 (6.00%) high severe
limit 512, 512 time: [400.88 ns 402.76 ns 404.82 ns]
change: [-2.9396% -1.4390% -0.1617%] (p = 0.04 <
0.05)
Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe
add_nulls_512 time: [974.42 ns 976.84 ns 979.38 ns]
change: [-4.7016% -3.1536% -1.6052%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low mild
2 (2.00%) high mild
4 (4.00%) high severe
divide_nulls_512 time: [2.8035 us 2.8104 us 2.8175 us]
change: [-2.5459% -1.3916% -0.4130%] (p = 0.01 <
0.05)
Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) low mild
4 (4.00%) high severe
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
