Dandandan commented on code in PR #9481:
URL: https://github.com/apache/arrow-datafusion/pull/9481#discussion_r1518789548
##########
datafusion/common/src/utils.rs:
##########
@@ -679,12 +679,32 @@ pub fn find_indices<T: PartialEq, S: Borrow<T>>(
.ok_or_else(|| DataFusionError::Execution("Target not
found".to_string()))
}
+pub trait EffectiveSize {
+ fn get_effective_memory_size(&self) -> usize;
+}
+
+impl EffectiveSize for ArrayRef {
+ fn get_effective_memory_size(&self) -> usize {
+ self.to_data().get_slice_memory_size().unwrap_or(0)
+ }
+}
+
+impl EffectiveSize for RecordBatch {
+ fn get_effective_memory_size(&self) -> usize {
Review Comment:
I don't think this is really what we want for memory tracking? If we slice a
batch, we still hold on to the original array (zero copy).
The slice itself has minimal metadata overhead, but the data remains in the
original batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
