alamb commented on code in PR #9524: URL: https://github.com/apache/arrow-datafusion/pull/9524#discussion_r1518812060
########## datafusion/functions/src/core/nullif.rs: ########## @@ -15,8 +15,6 @@ // specific language governing permissions and limitations // under the License. -//! Encoding expressions Review Comment: 👍 ########## datafusion/sqllogictest/test_files/functions.slt: ########## @@ -479,7 +479,7 @@ CREATE TABLE test( (3, 30); # Scalar function -statement error Did you mean 'arrow_typeof'? +statement error Invalid function 'arrowtypeof' Review Comment: I think this is tracked by https://github.com/apache/arrow-datafusion/issues/9392 @SteveLauC has a PR up for it https://github.com/apache/arrow-datafusion/pull/9407 which hopefully will land shortly ########## docs/source/user-guide/sql/data_types.md: ########## @@ -31,7 +31,7 @@ the `arrow_typeof` function. For example: ```sql select arrow_typeof(interval '1 month'); +-------------------------------------+ -| arrowtypeof(IntervalYearMonth("1")) | +| arrow_typeof(IntervalYearMonth("1")) | Review Comment: 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
