jayzhan211 commented on code in PR #9522:
URL: https://github.com/apache/arrow-datafusion/pull/9522#discussion_r1518824404
##########
datafusion/physical-expr/src/udf.rs:
##########
@@ -28,8 +29,22 @@ use std::sync::Arc;
pub fn create_physical_expr(
fun: &ScalarUDF,
input_phy_exprs: &[Arc<dyn PhysicalExpr>],
- return_type: DataType,
+ input_schema: &Schema,
+ args: &[Expr],
+ input_dfschema: &DFSchema,
) -> Result<Arc<dyn PhysicalExpr>> {
+ let input_expr_types = input_phy_exprs
Review Comment:
Do you mean they are checked in logical expr once, so we dont double check
them in physical expr?
If so, we can remove both in physical expr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
