alamb commented on code in PR #9521:
URL: https://github.com/apache/arrow-datafusion/pull/9521#discussion_r1518824399
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -468,11 +468,13 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
expr,
trim_where,
trim_what,
+ trim_characters,
Review Comment:
This is a pretty good example of the reason I prefer not to use `..` in
patching patterns
If we use `..` in the patterns and a new field is added, the compiler won't
tell you on update where you may have to use it.
I will make a follow on PR to ermove this `..` match
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
