alamb commented on code in PR #9531:
URL: https://github.com/apache/arrow-datafusion/pull/9531#discussion_r1518826765
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -478,7 +492,6 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
trim_where,
trim_what,
trim_characters,
- ..
Review Comment:
turns out there are no other fields. By removing `..` it means if any new
fields are added in future sqlparser releases they will need to be handled
explicitly
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -801,7 +814,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
distinct,
order_by,
null_treatment,
- ..
+ filter: None, // filter is passed in
Review Comment:
Rather than igorning this field, I added a check that it is `None`
(otherwise the filter could be potentially overridden silently). I don't think
this is possible currently, but now it is clear it can not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
