tustvold commented on code in PR #5477:
URL: https://github.com/apache/arrow-rs/pull/5477#discussion_r1518986373
##########
parquet/src/arrow/array_reader/mod.rs:
##########
@@ -47,6 +47,7 @@ mod test_util;
pub use builder::build_array_reader;
pub use byte_array::make_byte_array_reader;
pub use byte_array_dictionary::make_byte_array_dictionary_reader;
+#[allow(unused_imports)]
Review Comment:
```suggestion
#[allow(unused_imports)] // Only used for benchmarks
```
##########
parquet/src/compression.rs:
##########
@@ -441,8 +437,6 @@ mod lz4_codec {
}
}
}
-#[cfg(any(feature = "lz4", test))]
-pub use lz4_codec::*;
Review Comment:
This removal seems incorrect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
