thinkharderdev commented on PR #9436: URL: https://github.com/apache/arrow-datafusion/pull/9436#issuecomment-1988014140
> I think I need some feedback on [#9436 (comment)](https://github.com/apache/arrow-datafusion/pull/9436#discussion_r1510246296) and [#9436 (comment)](https://github.com/apache/arrow-datafusion/pull/9436#discussion_r1510296803) to continue this PR. 🤔 I think it is fine to replace `ScalarFunctionImplementation` with `ScalarUDF` and end up with something like: ``` pub struct ScalarFunctionExpr { fun: ScalarUDF, args: Vec<Arc<dyn PhysicalExpr>>, // Whether this function can be invoked with zero arguments supports_zero_argument: bool, } impl ScalarFunctionExpr { // Change this to return &ScalarUDF instead of &ScalarFunctionImplementation fn fun(&self) -> &ScalarUDF { &self.fun ] } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
