alamb commented on issue #9529:
URL:
https://github.com/apache/arrow-datafusion/issues/9529#issuecomment-1989192977
> @alamb, having it as the part of FunctionFactory would be ideal, imho.
Something like:
What about something like this (no changes to `FunctionFactory`, but
literally put it on the struct directly)
```rust
/// Configuration is stored specifically for this function factory
#[derive(Debug, Default)]
struct CustomFunctionFactory {
config: CustomConfigObject
}
```
What I am missing is the usecase for dynamically passing the configuration.
It would make sense if there was DDL like
```sql
CREATE FUNCTION FACTORY ...
```
Where you had to connect the configuration but didn't know it beforehand.
But if you have to make a `CustomFunctionFactory` instance anyway, why not just
give it the config directly 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
