bkietz commented on a change in pull request #9323:
URL: https://github.com/apache/arrow/pull/9323#discussion_r570419335
##########
File path: cpp/src/arrow/compute/kernels/vector_hash.cc
##########
@@ -76,6 +79,8 @@ class UniqueAction final : public ActionBase {
template <class Index>
void ObserveNotFound(Index index) {}
+ bool ShouldEncodeNulls() { return true; }
Review comment:
Making this explicitly constexpr (where possible) will help the compiler
drop dead code
```suggestion
constexpr bool ShouldEncodeNulls() const { return true; }
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
