ozankabak commented on code in PR #9382:
URL: https://github.com/apache/arrow-datafusion/pull/9382#discussion_r1520574998
##########
datafusion/sqllogictest/test_files/copy.slt:
##########
@@ -469,8 +474,8 @@ select * from validate_arrow;
# Error cases:
# Copy from table with options
-query error DataFusion error: Invalid or Unsupported Configuration: Found
unsupported option row_group_size with value 55 for JSON format!
-COPY source_table to 'test_files/scratch/copy/table.json' (row_group_size 55);
+query error DataFusion error: Internal error: Config value "row_group_size"
not found on JsonOptions.
Review Comment:
A configuration error, rather than an internal error, seems more appropriate
here.
##########
datafusion/sql/src/statement.rs:
##########
@@ -1456,3 +1469,43 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
.is_ok()
}
}
+
+pub fn try_infer_file_type(
Review Comment:
Needs a docstring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]