jayzhan211 commented on PR #9249: URL: https://github.com/apache/arrow-datafusion/pull/9249#issuecomment-1989859176
short summary for review: I think the current to discuss issue is to decide how can we have a flexible design for `create_accumulator`. FirstAccumulator introduce `ignore_nulls`, OrderSensitiveArrayAggAccumulator has `reverse` those are additional argument for them, the previous design does not consider the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
