waynexia commented on code in PR #9556:
URL: https://github.com/apache/arrow-datafusion/pull/9556#discussion_r1520779234
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -44,13 +42,13 @@ use datafusion_expr::{col, Expr, ExprSchemable};
/// - DataType of this expression.
type ExprSet = HashMap<Identifier, (Expr, usize, DataType)>;
-/// Identifier type. Current implementation use describe of a expression (type
String) as
+/// Identifier type. Current implementation use describe of an expression
(type String) as
/// Identifier.
///
-/// A Identifier should (ideally) be able to "hash", "accumulate", "equal" and
"have no
+/// An Identifier should (ideally) be able to "hash", "accumulate", "equal"
and "have no
Review Comment:
nit:
```suggestion
/// An identifier should (ideally) be able to "hash", "accumulate", "equal"
and "have no
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
