Omega359 opened a new issue, #9579:
URL: https://github.com/apache/arrow-datafusion/issues/9579

   ### Is your feature request related to a problem or challenge?
   
   Currently we cannot have any dev-dependencies in the Cargo.toml files that 
would cause circular references because cargo publish in all it's wisdom 
[doesn't exclude](https://github.com/rust-lang/cargo/issues/4242) 
dev-dependencies when publishing to crates.io. This causes issues with tests 
where we either have to move the test to some 'common' location when the test 
wants to use a dependency that we otherwise do not want in the crate (for 
example, a dependency on datafusion-functions in the physical-expr crate), 
remove the test or somehow rewrite the test to not require the dependency. This 
is pretty limiting and really shouldn't be an issue.
   
   I propose that the cargo publish commands that are used are tested with the 
[--no-dev-dependencies 
flag](https://github.com/taiki-e/cargo-hack#--no-dev-deps) from the hacks 
crate. If successful we could then once again allow the circular 
dev-dependencies which would ease testing.
   
   Note that this change would not allow for dev-dependencies in rust docs -- 
it would likely work locally but I believe would likely still fail when 
published.
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to