singhpk234 commented on code in PR #194:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/194#discussion_r1522051633
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1836,6 +1838,48 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
}
}
+ case join: ShuffledHashJoinExec if isCometOperatorEnabled(op.conf,
"hash_join") =>
+ if (join.buildSide == BuildRight) {
+ // DataFusion HashJoin assumes build side is always left.
+ // TODO: support BuildRight
Review Comment:
ACK, this makes sense so it's like comet shouldn't make any decisions making
changes on spark plan itself, and just focus on execution rather than planning
:) !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
