sunchao commented on code in PR #196:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/196#discussion_r1522186708
##########
spark/src/main/java/org/apache/spark/shuffle/sort/CometShuffleExternalSorter.java:
##########
@@ -257,6 +257,7 @@ private long getMemoryUsage() {
for (SpillSorter sorter : spillingSorters) {
totalPageSize += sorter.getMemoryUsage();
}
+ totalPageSize += activeSpillSorter.getMemoryUsage();
Review Comment:
I'm not sure how to test this in a unit test, but this is clearly something
missing. In the non-async path, only `activeSpillSorter` is used for sorting
and spilling, and currently `getMemoryUsage` doesn't take account of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
