jayzhan211 commented on code in PR #9583: URL: https://github.com/apache/arrow-datafusion/pull/9583#discussion_r1522308627
########## datafusion/functions-array/src/rewrite.rs: ########## @@ -0,0 +1,211 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Rewrites for using Array Functions + +use crate::concat::{array_append, array_concat}; +use crate::expr_fn::{array_has_all, array_prepend}; +use datafusion_common::config::ConfigOptions; +use datafusion_common::tree_node::Transformed; +use datafusion_common::utils::list_ndims; +use datafusion_common::{Column, DFSchema}; +use datafusion_expr::expr::ScalarFunction; +use datafusion_expr::expr_rewriter::FunctionRewrite; +use datafusion_expr::{ + BinaryExpr, BuiltinScalarFunction, Expr, GetFieldAccess, GetIndexedField, Operator, +}; + +/// Rewrites expressions into function calls to array functions +pub(crate) struct ArrayFunctionRewriter {} + +impl FunctionRewrite for ArrayFunctionRewriter { + fn name(&self) -> &str { + "FunctionRewrite" + } + + fn rewrite( + &self, + expr: Expr, + schema: &DFSchema, + _config: &ConfigOptions, + ) -> datafusion_common::Result<Transformed<Expr>> { + let transformed = match expr { + // array1 @> array2 -> array_has_all(array1, array2) + Expr::BinaryExpr(BinaryExpr { left, op, right }) Review Comment: I noticed that `cfg(array_expression)` is removed, is it fine? They are not needed after moving them to functions-array crate though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
