advancedxy opened a new pull request, #203:
URL: https://github.com/apache/arrow-datafusion-comet/pull/203

   ## Which issue does this PR close?
   Closes #.
   
   ## Rationale for this change
   When developing #179 and `CometRowToColumnar` support, I noticed suspicious 
errors. It turns out that scalafix in the java-test action rewrites the scala 
source code and have conflict result with `scalafmt`(used by spotless). It's 
hard to debug such cases and quite annoying. 
   
   ## What changes are included in this PR?
   1. enforce scalafix check in CI rather rewriting silently
   2. apply `scalafix:scalafix` to the current codebase
   3. refine `format` target in Makefile so that developers can format code by 
simply type: `make format`
   4. add a section about code formatting before submit a PR
   
   ## How are these changes tested?
   Existing test and CI checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to