advancedxy commented on code in PR #179:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/179#discussion_r1522758963
##########
pom.xml:
##########
@@ -494,6 +494,7 @@ under the License.
<spark.version>3.2.2</spark.version>
<spark.version.short>3.2</spark.version.short>
<parquet.version>1.12.0</parquet.version>
+ <additional.test.source>spark-3.2</additional.test.source>
Review Comment:
It's used in the plugin to configure additional test source.
```
<executions>
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
<goals>
<goal>add-test-source</goal>
</goals>
<configuration>
<sources>
<source>src/test/${additional.test.source}</source>
</sources>
</configuration>
</execution>
</executions>
```
If we don't add a placeholder here, the configuration will be wrong or has
to be configured conditionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
