tustvold commented on code in PR #5500:
URL: https://github.com/apache/arrow-rs/pull/5500#discussion_r1522776410
##########
object_store/src/limit.rs:
##########
@@ -81,18 +81,12 @@ impl<T: ObjectStore> ObjectStore for LimitStore<T> {
let _permit = self.semaphore.acquire().await.unwrap();
self.inner.put_opts(location, bytes, opts).await
}
- async fn put_multipart(
- &self,
- location: &Path,
- ) -> Result<(MultipartId, Box<dyn AsyncWrite + Unpin + Send>)> {
- let permit =
Arc::clone(&self.semaphore).acquire_owned().await.unwrap();
- let (id, write) = self.inner.put_multipart(location).await?;
- Ok((id, Box::new(PermitWrapper::new(write, permit))))
- }
-
- async fn abort_multipart(&self, location: &Path, multipart_id:
&MultipartId) -> Result<()> {
- let _permit = self.semaphore.acquire().await.unwrap();
- self.inner.abort_multipart(location, multipart_id).await
+ async fn upload(&self, location: &Path) -> Result<Box<dyn Upload>> {
Review Comment:
We can actually properly limit/throttle uploads now, as the public APIs now
mirror the underlying requests :tada:
This will also enable things like reliably running IO on a separate tokio
runtime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
