jayzhan211 commented on code in PR #9592:
URL: https://github.com/apache/arrow-datafusion/pull/9592#discussion_r1522933850
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -113,7 +114,22 @@ impl ExprSchemable for Expr {
.iter()
.map(|e| e.get_type(schema))
.collect::<Result<Vec<_>>>()?;
- Ok(arg_data_types[0].clone())
+ let arg_data_type = arg_data_types[0].clone();
Review Comment:
We have type checking in
https://github.com/apache/arrow-datafusion/blob/0302d6530a5a7fffe7da40e0f3b13794a9c693ff/datafusion/sql/src/expr/function.rs#L349-L361
so I think we dont need the duplicated check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
