tinfoil-knight opened a new pull request, #9594:
URL: https://github.com/apache/arrow-datafusion/pull/9594
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #9575
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
#9382 standardised write configuration but broke backwards compatibility for
the format specific options of the `COPY` command.
Earlier users could have a query like this without prefixing all options:
```
COPY source_table TO 'test_files/scratch/copy/format_table/' (
format parquet,
compression snappy,
'compression::col1' 'zstd(5)'
);
```
But after #9382, they'd need to prefix every format-specific options in this
verbose way:
```
COPY source_table TO 'test_files/scratch/copy/format_table/' (
format parquet,
'parquet.compression' snappy,
'parquet.compression::col1' 'zstd(5)'
);
```
This PR adds back the support for format-specific options that worked
without providing the format prefix.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
This PR renames keys without the file_type/format prefix for file types
supported by the `COPY` command for backwards compatibility.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
- Existing tests in `copy.slt` confirm that the prefixed format options (eg.
`(format json, 'json.compression' gzip)`) added in #9382 work & aren't broken.
- Tests have been added for the legacy format (eg. `(format json,
compression gzip)`).
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
Yes. But the current documentation
(https://arrow.apache.org/datafusion/user-guide/sql/write_options.html#available-options)
lists the legacy format so this PR doesn't require a doc update.
> If there are any breaking changes to public APIs, please add the `api
change` label.
This PR restores breaking changes so I'm not adding the `api change` label.
Please let me know if you think we should add the label nonetheless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
