alamb commented on code in PR #9590:
URL: https://github.com/apache/arrow-datafusion/pull/9590#discussion_r1523516945
##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -1510,44 +1447,6 @@ mod tests {
Utf8,
StringArray
);
- #[cfg(feature = "crypto_expressions")]
Review Comment:
I double checked and these functions are covered in .slt tests here
https://github.com/apache/arrow-datafusion/blob/30d2be9f581846c4b6f875424512eaa7310e16ab/datafusion/sqllogictest/test_files/expr.slt#L1373-L1556
I don't think there is any need to port these rust unit tests too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
