thinkharderdev commented on code in PR #5488:
URL: https://github.com/apache/arrow-rs/pull/5488#discussion_r1523904656
##########
arrow-flight/src/encode.rs:
##########
@@ -388,29 +388,39 @@ impl Stream for FlightDataEncoder {
/// Defines how a [`FlightDataEncoder`] encodes [`DictionaryArray`]s
///
/// [`DictionaryArray`]: arrow_array::DictionaryArray
+///
Review Comment:
Added
```
/// The current implementation does not support "delta" dictionaries so a
new dictionary batch will be sent each time the encoder sees a
/// dictionary which is not pointer-equal to the previously observed
dictionary for a given `dict_id`.
```
to clarify that we do not send delta dictionaries but the current
implementation will actually skip sending the dictionary if it is pointer-equal
to existing tracked dictionary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
