dianaclarke commented on a change in pull request #9431:
URL: https://github.com/apache/arrow/pull/9431#discussion_r571311540
##########
File path: dev/archery/tests/test_benchmarks.py
##########
@@ -17,26 +17,31 @@
from archery.benchmark.core import Benchmark, median
from archery.benchmark.compare import BenchmarkComparator
+from archery.benchmark.google import add_unit_to_name, extend_payload
def test_benchmark_comparator():
unit = "micros"
assert not BenchmarkComparator(
Benchmark("contender", unit, True, [10]),
- Benchmark("baseline", unit, True, [20])).regression
Review comment:
Black re-formatted these lines. I can revert the change if you like
though I do think this is better ;)
##########
File path: dev/archery/tests/test_benchmarks.py
##########
@@ -17,26 +17,31 @@
from archery.benchmark.core import Benchmark, median
from archery.benchmark.compare import BenchmarkComparator
+from archery.benchmark.google import add_unit_to_name, extend_payload
def test_benchmark_comparator():
unit = "micros"
assert not BenchmarkComparator(
Benchmark("contender", unit, True, [10]),
- Benchmark("baseline", unit, True, [20])).regression
Review comment:
Black re-formatted these lines. I can revert the change if you like,
though I do think this is better ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
