ZhangHuiGui commented on issue #40308: URL: https://github.com/apache/arrow/issues/40308#issuecomment-1996586961
> I thought that you refer Redshift's rules not our compute module's one. Actually our compute module's decimal rules is the same with Redshift's rules. Compute module implement the rules by two step: 1. Implicit cast. The logic is in `CastBinaryDecimalArgs`. 2. Output resolve. The logic is in `ResolveDecimalDivisionOutput`. All these two steps are in expression `Bind`, and form the rules same with `Redshift's numeric rules`. > I don't object that Gandiva can also use the rules but it breaks backward compatibility. Can we support both rules and use the current rule by default for compatibility? Agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
