alamb commented on a change in pull request #9379:
URL: https://github.com/apache/arrow/pull/9379#discussion_r571418161
##########
File path: rust/arrow/src/csv/writer.rs
##########
@@ -97,6 +97,8 @@ pub struct Writer<W: Write> {
has_headers: bool,
/// The date format for date arrays
date_format: String,
Review comment:
It seems like these fields are somewhat confusingly named -
`date_format` maybe could be called `date32_format` and `datetime_format` could
be called `date64_format` -- though perhaps the root source of the confusion is
that `Date32` is always in units of days and `Date64` is in units of
millisecond.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
