kou commented on PR #40545: URL: https://github.com/apache/arrow/pull/40545#issuecomment-1998490538
> does this mean I have to install and run an additional tool to properly format CMake changes? Yes. You need to install `pre-commit` by `conda install -c conda-forge pre-commit`/`pip install pre-commit`/`sudo apt install -y pre-commit` (Ubuntu 22.04+) and run `pre-commit run -a` instead of `archery lint`. Note that you don't need to install `cmake_format` separately like `pip install -e 'dev/archery[lint]'`. > The selling point of `archery lint` is that it handles everything by itself. This means that `archery lint` runs all lints (`cmake_format`, `clang-format` and so on), right? `pre-commit run -a` also does it eventually. I'll open PRs for it. For example, I'll add configurations of `clang-format` for `cpp/` and `python/` to `.pre-commit-config.yaml` like existing configuration of `c_glib/`: https://github.com/apache/arrow/blob/eecd7797f1d789551fbb000a93504182c47b6baa/.pre-commit-config.yaml#L55-L61 If you don't like removing `cmake_format` related codes from Archery before `pre-commit run -a` can replace `archery lint` entirely, I'll remove Archery related changes from this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
