doki23 commented on PR #5440: URL: https://github.com/apache/arrow-rs/pull/5440#issuecomment-1998672712
> Can we remove the APIs in terms of `O`, they're confusing imo and given the intended use with slices which have `usize` length, I think they're hard to use > > I also wonder if you saw this > > > In particular, tracking the in-progress size using usize, incrementing it using checked arithmetic, and converting to O with usize_as. Then at the end, i.e. in OffsetsBuilder::finish, checking if the value of usize overflows O. I'd also be very interested in any benchmarks of this approach. I get offset by add last offset with length, I have to convert length to `O`. A `push_length(&mut self, length: O)` may help reduce reduplicate code. @tustvold -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
