istvan-fodor commented on issue #9090:
URL:
https://github.com/apache/arrow-datafusion/issues/9090#issuecomment-1998676975
@alamb, @Omega359 I took at look at the benchmarks and I had some
questions.
It looks to me that the code that is benchmarked doesn't actually create
timestamps, it just creates the expressions that **if** evaluated would/should
return timestamps. I checked in the debugger and could never catch anything in
`ToTimestampFunc::invoke()`. Also, when I printed out the results of the
`to_timestamp` calls form the benchmark I saw these:
```
to_timestamp(Utf8("1997-01-31T09:26:56.123Z"), Utf8("%+"), Utf8("%c"),
Utf8("%Y-%m-%dT%H:%M:%S%.f%Z"))
to_timestamp(Utf8("1997-01-31T09:26:56.123-05:00"), Utf8("%+"), Utf8("%c"),
Utf8("%Y-%m-%dT%H:%M:%S%.f%z"))
to_timestamp(Utf8("1997-01-31 09:26:56.123-05:00"), Utf8("%+"), Utf8("%c"),
Utf8("%Y-%m-%d %H:%M:%S%.f%Z"))
to_timestamp(Utf8("2023-01-01 04:05:06.789 -08"), Utf8("%+"), Utf8("%c"),
Utf8("%Y-%m-%d %H:%M:%S%.f %#z"))
to_timestamp(Utf8("1997-01-31T09:26:56.123"), Utf8("%+"), Utf8("%c"),
Utf8("%Y-%m-%dT%H:%M:%S%.f"))
to_timestamp(Utf8("1997-01-31 09:26:56.123"), Utf8("%+"), Utf8("%c"),
Utf8("%Y-%m-%d %H:%M:%S%.f"))
to_timestamp(Utf8("1997-01-31 09:26:56"), Utf8("%+"), Utf8("%c"),
Utf8("%Y-%m-%d %H:%M:%S"))
to_timestamp(Utf8("1997-01-31 092656"), Utf8("%+"), Utf8("%c"),
Utf8("%Y-%m-%d %H%M%S"))
to_timestamp(Utf8("1997-01-31 092656+04:00"), Utf8("%+"), Utf8("%c"),
Utf8("%Y-%m-%d %H%M%S%:z"))
to_timestamp(Utf8("Sun Jul 8 00:34:60 2001"), Utf8("%+"), Utf8("%c"),
Utf8("%Y-%m-%d 00:00:00"))
```
Am I reading this right or am I missing this completely? Is the goal here to
speed up str -> timestamp creation or to speed up the creation of the
expression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
