Tom-Newton commented on PR #40021: URL: https://github.com/apache/arrow/pull/40021#issuecomment-1999480704
> After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit [9f6dc1f](https://github.com/apache/arrow/commit/9f6dc1feb52bebceb4b4bfd966f0160e27f9f40f). > > There were 7 benchmark results indicating a performance regression: > > * Commit Run on `ursa-i9-9960x` at [2024-03-13 23:17:43Z](https://conbench.ursa.dev/compare/runs/5576943c1e6f43c280d7933c76becac8...ec20e2f763aa4fada18dc58277d4139e/) > > * [`file-read` (Python) with compression=uncompressed, dataset=nyctaxi_2010-01, file_type=parquet, output_type=table](https://conbench.ursa.dev/compare/benchmarks/065f215cc3da7b96800077c791bfbffd...065f23dc91e17e478000707d350e2b82) > * [`dataset-selectivity` (Python) with dataset=nyctaxi_multi_ipc_s3, selectivity=1%](https://conbench.ursa.dev/compare/benchmarks/065f20f032d276948000d6684616e2b5...065f236edd9c733f8000a12d51dbe625) > * and 5 more (see the report linked below) > > The [full Conbench report](https://github.com/apache/arrow/runs/22644728360) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. I'm not really sure what to make of this. These benchmarks do seem potentially relevant but all I've done is add a feature not modify anything so I don't see how this PR could have caused a regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
