kou commented on code in PR #40571:
URL: https://github.com/apache/arrow/pull/40571#discussion_r1526236551
##########
ci/docker/linux-apt-docs.dockerfile:
##########
@@ -76,6 +76,9 @@ RUN apt-get purge -y npm && \
rm -rf /var/lib/apt/lists/* && \
npm install -g yarn
+# Expose ARROW_PYTHON_VENV from BASE
+ENV ARROW_PYTHON_VENV /arrow-dev
Review Comment:
Or how about defining `RETICULATE_PYTHON_ENV` here?
```dockerfile
ENV RETICULATE_PYTHON_ENV ${ARROW_PYTHON_VENV}
```
##########
ci/scripts/r_build.sh:
##########
@@ -31,6 +31,9 @@ ${R_BIN} CMD build .
${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz
if [ "${BUILD_DOCS_R}" == "ON" ]; then
+ if [ -n "${ARROW_PYTHON_VENV:-}" ]; then
+ RETICULATE_PYTHON_ENV=${ARROW_PYTHON_VENV}
Review Comment:
```suggestion
export RETICULATE_PYTHON_ENV=${ARROW_PYTHON_VENV}
```
##########
ci/docker/linux-apt-docs.dockerfile:
##########
@@ -76,6 +76,9 @@ RUN apt-get purge -y npm && \
rm -rf /var/lib/apt/lists/* && \
npm install -g yarn
+# Expose ARROW_PYTHON_VENV from BASE
+ENV ARROW_PYTHON_VENV /arrow-dev
Review Comment:
I think that we don't need this. (It should be inherited from the base image
automatically.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
