singhpk234 commented on code in PR #194:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/194#discussion_r1526615472
##########
core/src/execution/proto/operator.proto:
##########
@@ -87,3 +88,21 @@ message Expand {
repeated spark.spark_expression.Expr project_list = 1;
int32 num_expr_per_project = 3;
}
+
+message HashJoin {
Review Comment:
apologies, I wasn't clear in the comment above, I was thinking of something
like this :
```
message Join {
repeated spark.spark_expression.Expr left_join_keys = 1;
repeated spark.spark_expression.Expr right_join_keys = 2;
JoinType join_type = 3;
// can serve as condition in SHJ and sort_options in SMJ
repeated spark.spark_expression.Expr join_exprs = 4;
JoinExec join_exec = 5;
}
message JoinExec {
HashJoin = 0;
SMJ = 1;
....
}
```
may be it's too much and having diff proto msg for each join should be right
thing to do !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
