huaxingao commented on code in PR #9625:
URL: https://github.com/apache/arrow-datafusion/pull/9625#discussion_r1526625663
##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -249,7 +249,6 @@ fn create_built_in_window_expr(
.clone()
.try_into()
.map_err(|e| DataFusionError::Execution(format!("{e:?}")))?;
- let n: u32 = n as u32;
Review Comment:
I am not sure if we want to support negative index in `NTH_VALUE` or not. If
we want to support, then this line needs to be removed. Otherwise, we probably
want to add a check to explicitly block negative index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
