joellubi commented on PR #1590:
URL: https://github.com/apache/arrow-adbc/pull/1590#issuecomment-2000250309
@lidavidm @zeroshade I think I've just about wrapped this up. The
driverbase package is now internal, and I've rebased on top of the recent
session options changes and refactored the flightsql current catalog/schema
code to use the helper methods. Let me know what you think.
There is one remaining issue that I have yet to resolve, if you have any
ideas what the issue might be it would be very helpful: There is an integration
test that's been failing (`Integration / FlightSQL Integration Tests (Dremio
and SQLite)`). It seems to be related to these changes but I haven't yet
figured out how. I'm seeing errors like this for `GetInfo` from sqlite:
```
Expected: has substring "db_name"
Actual: "n\a\0\0\0\0\0"
```
and
```
Expected: has substring "sqlite 3"
Actual: "n\a\0\0\0\0\0\0"
```
although the "actual" values have varied between runs. Any thoughts on what
this might be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
