matthewgapp commented on PR #9619: URL: https://github.com/apache/arrow-datafusion/pull/9619#issuecomment-2000367300
Looks great, @jonahgao—thanks for taking this on. Would it be sensible to have the worktable's update method take a `ReservedBatches` as an argument, instead of constructing it internally? My thinking is that, given worktable's sole purpose is to facilitate the recursive query, tightening the integration with `ReservedBatches` could better illustrate to future contributors the coupled ownership relationship between a `RecordBatch`'s buffer's and its corresponding memory reservation. And apologies that I've been a bit radio silent on this front @alamb! Been heads down on other stuff :/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
