erratic-pattern commented on code in PR #40243:
URL: https://github.com/apache/arrow/pull/40243#discussion_r1527007991
##########
format/FlightSql.proto:
##########
@@ -1797,6 +1797,27 @@ message DoPutUpdateResult {
int64 record_count = 1;
}
+/* An *optional* response returned when `DoPut` is called with
`CommandPreparedStatementQuery`.
+ *
+ * *Note on legacy behavior*: previous versions of the protocol did not return
any result for
+ * this command, and that behavior should still be supported by clients. See
documentation
+ * of individual fields for more details on expected client behavior in this
case.
Review Comment:
> Maybe we could phrase this in terms of what happens in the case where
clients or servers don't support this new message
I wanted to avoid documenting information about individual fields in the
message, since the message might one day contain many fields.
I think I could simplify the wording on this to just indicate that older
servers dont use this, clients should support that, and just use the default
blank values for fields in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
