jayzhan211 commented on code in PR #9628:
URL: https://github.com/apache/arrow-datafusion/pull/9628#discussion_r1527034479
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1405,12 +1409,116 @@ impl<'a, S: SimplifyInfo> TreeNodeRewriter for
Simplifier<'a, S> {
Transformed::yes(lit(false))
}
+ // expr IN () --> false
+ // expr NOT IN () --> true
+ Expr::InList(InList {
+ expr,
+ list,
+ negated,
+ }) if list.is_empty() && *expr != Expr::Literal(ScalarValue::Null)
=> {
+ Transformed::yes(lit(negated))
+ }
+
+ // null in (x, y, z) --> null
+ // null not in (x, y, z) --> null
+ Expr::InList(InList {
+ expr,
+ list: _,
+ negated: _,
+ }) if is_null(expr.as_ref()) => Transformed::yes(lit_bool_null()),
+
+ // expr IN ((subquery)) -> expr IN (subquery), see ##5529
+ Expr::InList(InList {
+ expr,
+ mut list,
+ negated,
+ }) if list.len() == 1
+ && matches!(list.first(), Some(Expr::ScalarSubquery { .. })) =>
+ {
+ let Expr::ScalarSubquery(subquery) = list.remove(0) else {
+ unreachable!()
+ };
+
+ Transformed::yes(Expr::InSubquery(InSubquery::new(
+ expr, subquery, negated,
+ )))
+ }
+
+ // Combine multiple OR expressions into a single IN list
expression if possible
+ //
+ // i.e. `a = 1 OR a = 2 OR a = 3` -> `a IN (1, 2, 3)`
+ Expr::BinaryExpr(BinaryExpr {
+ left,
+ op: Operator::Or,
+ right,
+ }) if are_inlist_and_eq(left.as_ref(), right.as_ref()) => {
Review Comment:
After [deref pattern](https://github.com/rust-lang/rust/issues/87121) is
supported in stable rust, we can done the matching easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
