alamb commented on code in PR #9627:
URL: https://github.com/apache/arrow-datafusion/pull/9627#discussion_r1527164175
##########
datafusion/expr/src/expr_rewriter/mod.rs:
##########
@@ -399,20 +374,20 @@ mod test {
}
#[test]
- #[allow(deprecated)]
+ #[ignore = "investigate if this test is needed"]
Review Comment:
I looked at this test and I think it should just be removed (as it is
testing a behavior that was removed). The new behavior is covered by
```rust
#[test]
fn normalize_cols() {
```
Right above it
##########
datafusion/expr/src/expr_rewriter/mod.rs:
##########
@@ -399,20 +374,20 @@ mod test {
}
#[test]
- #[allow(deprecated)]
+ #[ignore = "investigate if this test is needed"]
Review Comment:
I pushed a commit to remove the test to your branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
